Support actions and reusable workflows from private repos #32562

Zettat123 · 2024-11-19T09:35:39Z

Resolve https://gitea.com/gitea/act_runner/issues/102

This PR allows administrators of a private repository to specify some collaborative owners. The repositories of collaborative owners will be allowed to access this repository's actions and workflows.

Settings for private repos:

This PR also moves "Enable Actions" setting to Actions > General page

Zettat123 · 2024-11-20T08:18:46Z

~~To support this feature, act_runner also needs some improvements, which I am working on.~~

For changes in act_runner, see https://gitea.com/gitea/act/pulls/123

Zettat123 · 2024-11-22T09:10:06Z

Docs: https://gitea.com/gitea/docs/pulls/107

routers/web/repo/githttp.go

lunny · 2024-12-21T00:11:21Z

Is this related to #24635 ?

SamuNatsu · 2025-07-05T03:42:54Z

Any progress for it?

IBims1ckoky · 2025-08-06T09:51:24Z

Any progress there?

codeguy · 2025-08-30T16:29:27Z

Any movement here? This would really really help us in our Gitea Cloud account.

lunny · 2025-08-30T17:48:54Z

Any movement here? This would really really help us in our Gitea Cloud account.

~~I will take the task.~~

routers/web/repo/githttp.go

models/perm/access/repo_permission.go

ChristopherHX · 2025-10-25T16:13:00Z

EDIT My fault test-repo was public instead of private

Could it be a private org is broken? Or is this nightly act_runner from https://dl.gitea.com/ not up to date.

test-runner(version:v0.2.13-3-g3b11bac) received task 6 of job test, be triggered by event: push
workflow prepared
evaluating expression 'success()'
expression 'success()' evaluated to 'true'
☁ git clone 'http://localhost:3005/private-actions/actions' # ref=main
cloning http://localhost:3005/private-actions/actions to /Users/christopher/.cache/act/5eac0f0b31fdc5958b4a6e5102b8d6235e0c4c726cc6a1300814391765f96d54
Unable to clone http://localhost:3005/private-actions/actions refs/heads/main: repository not found: Repository not found
repository not found: Repository not found
skipping post step for 'Checkout code'; step was not executed
Cleaning up container for job test
🏁 Job failed
repository not found: Repository not found

Or the server_url is incorrect etc.

Zettat123 · 2025-10-25T16:43:44Z

Could it be a private org is broken? Or is this nightly act_runner from https://dl.gitea.com/ not up to date.

I can't reproduce this issue. Can you make test01/test-repo private and try again?

ChristopherHX · 2025-10-25T16:44:55Z

well good point, missed my own repo visibility.

ChristopherHX

Looks good to me, we could later enhance troubleshooting

by log more information around repository not found
if act_runner did an authenticated pull

ChristopherHX · 2025-10-25T16:52:49Z

act could check own repo visibility in it's payload when getting repository not found with token and log an actionable message

wxiaoguang · 2025-10-26T04:48:30Z

templates/repo/settings/actions_general.tmpl

+			<div class="inline field">
+				<label>{{ctx.Locale.Tr "actions.actions"}}</label>
+				<div class="ui checkbox{{if $isActionsGlobalDisabled}} disabled{{end}}"{{if $isActionsGlobalDisabled}} data-tooltip-content="{{ctx.Locale.Tr "repo.unit_disabled"}}"{{end}}>
+					<input class="enable-system" name="enable_actions" type="checkbox" {{if $isActionsGlobalDisabled}}disabled{{end}} {{if $isActionsEnabled}}checked{{end}}>


What is enable-system?

wxiaoguang · 2025-10-26T04:49:06Z

templates/repo/settings/actions_general.tmpl

+	{{if and .EnableActions (.Permission.CanRead ctx.Consts.RepoUnitTypeActions)}}
+	{{if .Repository.IsPrivate}}


No indention?

wxiaoguang · 2025-10-26T04:53:00Z

templates/repo/settings/options.tmpl

-					<div class="inline field">
-						<label>{{ctx.Locale.Tr "actions.actions"}}</label>
-							<div class="ui checkbox{{if $isActionsGlobalDisabled}} disabled{{end}}"{{if $isActionsGlobalDisabled}} data-tooltip-content="{{ctx.Locale.Tr "repo.unit_disabled"}}"{{end}}>
-							<input class="enable-system" name="enable_actions" type="checkbox" {{if $isActionsEnabled}}checked{{end}}>


~~Won't it cause bug since you remove this block? RepoSettingForm.EnableActions is always false now, then any edit on this page will disable the Actiosn unit?~~

RepoSettingForm.EnableActions is left there and need to be removed.

wxiaoguang · 2025-10-26T04:53:57Z

models/perm/access/repo_permission.go

+			return perm, err
+		}
+		actionsCfg := repo.MustGetUnit(ctx, unit.TypeActions).ActionsConfig()
+		if !actionsCfg.IsCollaborativeOwner(taskRepo.OwnerID) || !taskRepo.IsPrivate {


Is it right if the owner's visibility is not public?

wxiaoguang · 2025-10-28T11:52:19Z

I "fixed" these reviews in Remove unnecessary code #35761

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 19, 2024

pull-request-size bot added the size/M label Nov 19, 2024

github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Nov 19, 2024

pull-request-size bot added size/L and removed size/M labels Nov 20, 2024

Zettat123 marked this pull request as ready for review November 20, 2024 08:17

Zettat123 marked this pull request as draft November 25, 2024 02:39

yp05327 reviewed Nov 25, 2024

View reviewed changes

routers/web/repo/githttp.go Outdated Show resolved Hide resolved

yp05327 reviewed Nov 25, 2024

View reviewed changes

routers/web/repo/githttp.go Outdated Show resolved Hide resolved

github-actions bot added modifies/api This PR adds API routes or modifies them modifies/frontend labels Nov 26, 2024

techknowlogick removed the size/L label Apr 10, 2025

Zettat123 force-pushed the private-reusable-workflow branch from 01211b3 to 82d368c Compare September 17, 2025 00:29

Zettat123 added 3 commits October 7, 2025 18:21

actions from private repos

d2d51c4

lint & fix test

688bd6d

remove task.LoadRepository

01035bd

Zettat123 force-pushed the private-reusable-workflow branch from 203ad9c to 01035bd Compare October 8, 2025 00:21

Zettat123 added 2 commits October 7, 2025 19:38

fix lint

e06b193

2024 -> 2025

802ed55

Zettat123 marked this pull request as ready for review October 8, 2025 01:49

lunny reviewed Oct 8, 2025

View reviewed changes

routers/web/repo/githttp.go Outdated Show resolved Hide resolved

add fixme again

80681e0

ChristopherHX reviewed Oct 22, 2025

View reviewed changes

models/perm/access/repo_permission.go Show resolved Hide resolved

Zettat123 added 7 commits October 22, 2025 15:44

fix err message

edb6bc4

update test

9c33b96

use ctx.JSON

1df6c57

check token in test

90a31b0

fix test

e4c2f4b

fix lint

3ec3d60

Merge branch 'main' into private-reusable-workflow

bb3d67f

Zettat123 marked this pull request as ready for review October 25, 2025 14:40

Merge branch 'main' into private-reusable-workflow

7e71bea

ChristopherHX approved these changes Oct 25, 2025

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2025

lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 25, 2025

Merge branch 'main' into private-reusable-workflow

1778615

lunny enabled auto-merge (squash) October 25, 2025 17:22

lunny merged commit c9beb0b into go-gitea:main Oct 25, 2025
26 checks passed

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 25, 2025

wxiaoguang reviewed Oct 26, 2025

View reviewed changes

wxiaoguang deleted the private-reusable-workflow branch October 28, 2025 11:49

wxiaoguang mentioned this pull request Oct 28, 2025

Remove unnecessary code and fix comments #35761

Open

		{{if and .EnableActions (.Permission.CanRead ctx.Consts.RepoUnitTypeActions)}}
		{{if .Repository.IsPrivate}}

Uh oh!

Uh oh!

Support actions and reusable workflows from private repos #32562

Support actions and reusable workflows from private repos #32562

Conversation

Zettat123 commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zettat123 commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zettat123 commented Nov 22, 2024

Uh oh!

Uh oh!

Uh oh!

lunny commented Dec 21, 2024

Uh oh!

SamuNatsu commented Jul 5, 2025

Uh oh!

IBims1ckoky commented Aug 6, 2025

Uh oh!

codeguy commented Aug 30, 2025

Uh oh!

lunny commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChristopherHX commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zettat123 commented Oct 25, 2025

Uh oh!

ChristopherHX commented Oct 25, 2025

Uh oh!

ChristopherHX left a comment

Choose a reason for hiding this comment

Uh oh!

ChristopherHX commented Oct 25, 2025

Uh oh!

Uh oh!

wxiaoguang Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

wxiaoguang commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Zettat123 commented Nov 19, 2024 •

edited

Loading

Zettat123 commented Nov 20, 2024 •

edited

Loading

lunny commented Aug 30, 2025 •

edited

Loading

ChristopherHX commented Oct 25, 2025 •

edited

Loading

wxiaoguang Oct 26, 2025 •

edited

Loading